fix: respect errorStack option in stats output (#15980)#20258
Merged
alexander-akait merged 2 commits intowebpack:mainfrom Dec 22, 2025
Merged
fix: respect errorStack option in stats output (#15980)#20258alexander-akait merged 2 commits intowebpack:mainfrom
alexander-akait merged 2 commits intowebpack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: fa6e5a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d7ed708 to
f665e32
Compare
CodSpeed Performance ReportMerging #20258 will not alter performanceComparing Summary
|
alexander-akait
requested changes
Dec 21, 2025
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Let's improve test cases
| }); | ||
| } | ||
| ] | ||
| }; |
Member
There was a problem hiding this comment.
Let's add a test case where we print stack trace, i.e. errorStack: true and we can merge, thank you
Contributor
Author
There was a problem hiding this comment.
ok let me add it
The errorStack extractor was not checking the errorStack option before adding stack traces to error output. This caused stack traces to be printed even when stats.errorStack was set to false. This fix adds a check for the errorStack option, similar to how errorDetails checks its corresponding option. Added test cases for both errorStack: false and errorStack: true.
f665e32 to
1c8860e
Compare
alexander-akait
approved these changes
Dec 21, 2025
Contributor
|
This PR is packaged and the instant preview is available (3bd18bb). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@3bd18bb
yarn add -D webpack@https://pkg.pr.new/webpack@3bd18bb
pnpm add -D webpack@https://pkg.pr.new/webpack@3bd18bb |
This was referenced Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15980.
The
errorStackextractor was not checking theerrorStackoption before adding stack traces to error output. This caused stack traces to be printed even whenstats.errorStackwas set tofalse.This fix adds a check for the
errorStackoption, similar to howerrorDetailschecks its corresponding option.What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes. Added a regression test case:
test/statsCases/error-stack-disabled-error/It verifies that when
stats.errorStack: falseis set, error stack traces are not included in the stats output.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes.